IC 20200304 #27
Merged
IC 20200304 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change TO_LAB to use the OSAL socket API rather than calling BSD sockets functions directly.
This creates a TO_LAB_Global namespace to isolate these global variables from other modules and prevent collision.
Follow the naming conventions in the CFE naming convention document and follow message processing patterns from other modules. - Separate each command into a separate handler function - Each command handler accepts a const pointer to the full message - Put Telemetry payload into a separate "Payload" sub-structure
This was
linked to
issues
Mar 10, 2020
alanc98
pushed a commit
to alanc98/to_lab
that referenced
this pull request
Jan 26, 2022
Fix nasa#16, Release Prep Document and copyright header changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration candidate 20200304
Fixes #15, #22, and #23
See PR #24 for more details.
Testing performed
CI Testing only
Expected behavior changes
#15 - Use OSAL socket API instead of BSD Sockets
#22 - Global namespace to isolate variables
#23 - Follow cFE naming convention document
System(s) tested on
Ubuntu
Additional context
See PR #24 for more details.
Third party code
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz NASA/GSFC