Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TO_LAB should put all global variables into a global structure #23

Closed
jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #24 or #27
Closed

TO_LAB should put all global variables into a global structure #23

jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #24 or #27

Comments

@jphickey
Copy link
Contributor

jphickey commented Feb 7, 2020

Is your feature request related to a problem? Please describe.
TO_LAB has several "bare" global variables, which are not namespace-qualified. These should all be put into a global structure, similar to the way other modules isolate their global varables.

Describe the solution you'd like
Implement a TO_LAB_Global data structure to isolate these values from the global namespace.

Additional context
Note that global variables in shared objects are by default put into a "common" section which can have weird effects on namespace clashes. This is why it is important to put them into a struct (which in this case is basically a namespace isolation mechanism).

Requester Info
Joseph Hickey, Vantage Systems Inc.
jphickey added a commit to jphickey/to_lab that referenced this issue Feb 7, 2020
@jphickey
Fix nasa#23: Put all globals into structure
d041045 
This creates a TO_LAB_Global namespace to isolate these
global variables from other modules and prevent collision.
@jphickey jphickey mentioned this issue Feb 7, 2020
Merged
jphickey added a commit to jphickey/to_lab that referenced this issue Feb 11, 2020
@jphickey
Merge nasa#15, nasa#22, nasa#23 into EDS baseline
ab21514 
This reflects general issues/patches to the upstream repository that
need to be resolved for EDS support
jphickey added a commit to jphickey/to_lab that referenced this issue Mar 2, 2020
@jphickey
Fix nasa#23: Put all globals into structure
7bbab8e 
This creates a TO_LAB_Global namespace to isolate these
global variables from other modules and prevent collision.
astrogeco pushed a commit that referenced this issue Mar 9, 2020
@jphickey @astrogeco
Fix #23: Put all globals into structure
21eb622 
This creates a TO_LAB_Global namespace to isolate these
global variables from other modules and prevent collision.
@astrogeco astrogeco mentioned this issue Mar 10, 2020
Merged
@astrogeco astrogeco linked a pull request Mar 10, 2020 that will close this issue
IC 20200304 #27
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple cleanup items for TO_LAB jphickey/to_lab
IC 20200304 nasa/to_lab
1 participant
@jphickey