Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cmake mimimum required to something more recent #117

Closed
jphickey opened this issue Jun 28, 2022 · 0 comments · Fixed by #118 or #119
Closed

Update cmake mimimum required to something more recent #117

jphickey opened this issue Jun 28, 2022 · 0 comments · Fixed by #118 or #119

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The cmake_minimum_required command currently lists a very old version. In fact some of the CFE/CFS build scripts assume at least version 3.5 to support things like target-specific includes and flags.

Notably, when using a recent version of cmake (e.g. 3.20) this generates a warning that says:

CMake Deprecation Warning at /home/jphickey/code/cfecfs/dtn/apps/sch_lab/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Describe the solution you'd like
Update the cmake_minimum_version to 3.5 (this would match CFE)

Describe alternatives you've considered
Disable warning?

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/sch_lab that referenced this issue Jun 28, 2022
@jphickey
Fix nasa#117, update cmake_minimum_required
2b19ca8 
Fixes the warning that support for old versions will be removed
The build does not actually expect such an old version
@jphickey jphickey mentioned this issue Jun 28, 2022
Merged
dzbaker added a commit that referenced this issue Jul 6, 2022
@dzbaker
Merge pull request #118 from jphickey/fix-117-update-cmake-min
90c6429 
Fix #117, update cmake_minimum_required
dzbaker added a commit to nasa/cFS that referenced this issue Jul 7, 2022
@dzbaker
IC: Caelum-rc4+dev12
cce10ef 
*Combines:*

osal v6.0.0-rc4+dev93
ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev24
sch_lab v2.5.0-rc4+dev31

**Includes:**

- nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES

*Update Minimum CMake Version*
- nasa/osal#1267, Update minimum required cmake version
- nasa/ci_lab#113, update cmake_minimum_required
- nasa/sch_lab#117, update cmake_minimum_required

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
Co-authored by: Ariel Adams    <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
This was referenced Jul 7, 2022
Merged
Merged
dzbaker added a commit to nasa/cFS that referenced this issue Jul 8, 2022
@dzbaker
IC: Caelum-rc4+dev12
bbd81ec 
*Combines:*

osal v6.0.0-rc4+dev93
ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev24
sch_lab v2.5.0-rc4+dev31

**Includes:**

- nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES

*Update Minimum CMake Version*
- nasa/osal#1267, Update minimum required cmake version
- nasa/ci_lab#113, update cmake_minimum_required
- nasa/sch_lab#117, update cmake_minimum_required

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
Co-authored by: Ariel Adams    <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jphickey