Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1263, Update minimum required cmake version #1267

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 5, 2022

Checklist (Please check before submitting)

Describe the contribution

This updates the main minimum required version from 2.8.12 to 3.5

Testing performed
CI

Expected behavior changes
None, just updates minimum required version

System(s) tested on
CI

Additional context

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 5, 2022
@skliper skliper added this to the Draco milestone Jul 5, 2022
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jul 6, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 7, 2022
*Combines:*

osal v6.0.0-rc4+dev93
ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev24
sch_lab v2.5.0-rc4+dev31

**Includes:**

- nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES

*Update Minimum CMake Version*
- nasa/osal#1267, Update minimum required cmake version
- nasa/ci_lab#113, update cmake_minimum_required
- nasa/sch_lab#117, update cmake_minimum_required

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
Co-authored by: Ariel Adams    <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
@dzbaker dzbaker merged commit 0df95c1 into nasa:main Jul 8, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 8, 2022
*Combines:*

osal v6.0.0-rc4+dev93
ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev24
sch_lab v2.5.0-rc4+dev31

**Includes:**

- nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES

*Update Minimum CMake Version*
- nasa/osal#1267, Update minimum required cmake version
- nasa/ci_lab#113, update cmake_minimum_required
- nasa/sch_lab#117, update cmake_minimum_required

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
Co-authored by: Ariel Adams    <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
@skliper skliper deleted the fix1263-cmake_minimum_version branch September 19, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cmake mimimum required to something more recent (or remove)
2 participants