-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #628, Update UtAssert macros with dynamic string formatting #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgibson
added
enhancement
unit-test
Tickets related to the OSAL unit testing (functional and/or coverage)
labels
Oct 21, 2020
jphickey
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
skliper
approved these changes
Oct 22, 2020
skliper
added
the
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
label
Oct 22, 2020
astrogeco
added
CCB-20201028
conflicts
and removed
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Oct 28, 2020
CCB 2020-10-28 APPROVED |
@asgibson can you resolve the merge conflicts on this? |
astrogeco
changed the title
Updated UtAssert macros to use dynamic string formatting
Fix #628, Update UtAssert macros with dynamic string formatting
Nov 3, 2020
@asgibson I went ahead and rebased your branch on top of integration-candidate, two tips for next time:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Changed all UtAssert macros to take variable string arguments, feature request #628
Testing performed
Steps taken to test the contribution, cFS/main branch commit 20097ef64e455ace25a1535ea43090a739eb7c0c:
https://github.com/nasa/cFS/
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
UtAssert_True wrapper around call will no longer be necessary to accommodate dynamic string output, thus removing the double assert. UtAssert macros will now be able to offer more information by themselves.
System(s) tested on
PC, RHEL 7.6
Contributor Info - All information REQUIRED for consideration of pull request
Alan Gibson NASA GSFC/587