Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In utassert.h allow all UtAssert macros to use UtAssertEx and __VA_ARGS__ for dynamic output strings #628

Closed
asgibson opened this issue Oct 21, 2020 · 0 comments · Fixed by #639
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@asgibson
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I have to add UtAssert_True as an outer shell to any of the asserts that do not use dynamic arguments.

Describe the solution you'd like
Update all the macros (except for UtAssert_Simple) to use UtAssertEx as the base function, removing description and adding VA_ARGS.

Describe alternatives you've considered
UtAssert_True wrapper around calls, but this results in two asserts per check which is unnecessary.

Additional context
Wrote up the change and did not see any issues while building or running tests.

Requester Info
Alan Gibson NASA GSFC/587

@asgibson asgibson added enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage) labels Oct 21, 2020
astrogeco added a commit that referenced this issue Nov 3, 2020
Fix #628, Update UtAssert macros with dynamic string formatting
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants