Fix #1328, always provide UT stub library #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "ut_osapi_stubs" library is mostly relevant for testing other applications, as opposed to testing OSAL itself. Therefore this library should be provided regardless of whether OSAL is being tested.
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 17, 2022
*Combines:* osal v6.0.0-rc4+devtbd **Includes:** *cFS* - #598 - #611 *osal* - nasa/osal#1335 - nasa/osal#1329 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 17, 2022
*Combines:* osal v6.0.0-rc4+devtbd **Includes:** *cFS* - #598 - #611 *osal* - nasa/osal#1335 - nasa/osal#1329 - nasa/osal#1336 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 17, 2022
*Combines:* osal v6.0.0-rc4+dev161 **Includes:** *cFS* - #598 - #611 *osal* - nasa/osal#1335 - nasa/osal#1329 - nasa/osal#1336 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Move the UT stub library so it is not dependent on ENABLE_UNIT_TESTS
The "ut_osapi_stubs" library is mostly relevant for testing other applications, as opposed to testing OSAL itself. Therefore this library should be provided regardless of whether OSAL is being tested.
Fixes #1328
Testing performed
Build and check OSAL in standalone build and CFE build
Expected behavior changes
The
ut_osapi_stubslibrary is always availableSystem(s) tested on
Ubuntu 22.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.