Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #991, Add count sem timeout test #1026

Merged

Conversation

zanzaben
Copy link
Contributor

@zanzaben zanzaben commented May 18, 2021

Describe the contribution
Fixes #991
Adds count semaphore timeout test

Testing performed
Build and run unit test

Expected behavior changes
Adds about 8 seconds to unit tests.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben force-pushed the fix991_CountSemTimedWait_Test branch from cb84b5e to 076164e Compare May 19, 2021 12:44
@zanzaben zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 19, 2021
@astrogeco
Copy link
Contributor

CCB:2021-05-19 APPROVED

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 19, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate May 24, 2021 17:21
@astrogeco astrogeco merged commit 8643a9c into nasa:integration-candidate May 24, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request May 24, 2021
Combines:

- nasa/cFE#1568
- nasa/osal#1050

Includes:

- nasa/cFE#1524, add printf format casts
- nasa/cFE#1520, accept "NULL" as entry point
- nasa/cfe #1549, add capability to generate multiple tables

- nasa/osal#1026, Add count sem timeout test
astrogeco added a commit to nasa/cFS that referenced this pull request May 26, 2021
Combines:

- cfe v6.8.0-rc1+dev593 (nasa/cFE#1568)
- osal v5.1.0-rc1+dev458 (nasa/osal#1050)

Includes:

- nasa/cFE#1524, add printf format casts
- nasa/cFE#1520, accept "NULL" as entry point
- nasa/cfe #1549, add capability to generate multiple tables
- nasa/cFE#1551, fixes discrepancies (return type, parameter names, etc) between function protoypes and implementation. Updates stubs accordingly

- nasa/osal#1026, Add count sem timeout test
- nasa/osal#1026, defer cancellation when BSP locked
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functional test to confirm OS_CountSemTimedWait waits up to the requested amount of time
3 participants