Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test status code discrepancies in osapi-binsem.h #1008

Closed
30 tasks done
jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1040 or #1058
Closed
30 tasks done

Unit test status code discrepancies in osapi-binsem.h #1008

jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1040 or #1058
Assignees
@jphickey
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented May 12, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
The unit tests and API documentation should match, where all status codes in the API documentation are tested in a unit test, and likewise all codes being tested for are documented in the API.

Describe the solution you'd like
Resolve the following mismatches:
File src/os/inc/osapi-binsem.h, function OS_BinSemCreate():

  • ONLY IN TEST: OS_ERROR
  • OK: OS_ERR_NAME_TAKEN
  • OK: OS_ERR_NAME_TOO_LONG
  • OK: OS_ERR_NO_FREE_IDS
  • OK: OS_INVALID_POINTER
  • ONLY IN DOXY: OS_SEM_FAILURE
  • OK: OS_SUCCESS

File src/os/inc/osapi-binsem.h, function OS_BinSemFlush():

  • OK: OS_ERR_INVALID_ID
  • ONLY IN DOXY: OS_SEM_FAILURE
  • OK: OS_SUCCESS

File src/os/inc/osapi-binsem.h, function OS_BinSemGive():

  • OK: OS_ERR_INVALID_ID
  • ONLY IN DOXY: OS_SEM_FAILURE
  • OK: OS_SUCCESS

File src/os/inc/osapi-binsem.h, function OS_BinSemTake():

  • OK: OS_ERR_INVALID_ID
  • ONLY IN DOXY: OS_SEM_FAILURE
  • OK: OS_SUCCESS

File src/os/inc/osapi-binsem.h, function OS_BinSemTimedWait():

  • OK: OS_ERR_INVALID_ID
  • ONLY IN DOXY: OS_SEM_FAILURE
  • OK: OS_SEM_TIMEOUT
  • OK: OS_SUCCESS

File src/os/inc/osapi-binsem.h, function OS_BinSemDelete():

  • OK: OS_ERR_INVALID_ID
  • ONLY IN DOXY: OS_SEM_FAILURE
  • OK: OS_SUCCESS

File src/os/inc/osapi-binsem.h, function OS_BinSemGetIdByName():

  • OK: OS_ERR_NAME_NOT_FOUND
  • OK: OS_ERR_NAME_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-binsem.h, function OS_BinSemGetInfo():

  • OK: OS_ERR_INVALID_ID
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

Additional context
Originally noted in #331, split into separate work items.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label May 12, 2021
@skliper skliper added this to the 6.0.0 milestone May 12, 2021
@jphickey jphickey self-assigned this May 21, 2021
jphickey added a commit to jphickey/osal that referenced this issue May 21, 2021
@jphickey
Fix nasa#1008, resolve descrepancies between binsem API and unit tests
d9ff939 
Ensures correlation between the unit-tests and documented return
values for the OSAL binsem API.
@jphickey jphickey mentioned this issue May 21, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue May 26, 2021
@jphickey
Fix nasa#1008, resolve discrepancies between binsem API and unit tests
5ca529b 
Ensures correlation between the unit-tests and documented return
values for the OSAL binsem API.
astrogeco added a commit that referenced this issue Jun 1, 2021
@astrogeco
Merge pull request #1040 from jphickey/fix-1008-binsem-api-retcodes
d5c8fc4 
Fix #1008, resolve discrepancies between binsem API and unit tests
@astrogeco astrogeco mentioned this issue Jun 1, 2021
Merged
pepepr08 pushed a commit to pepepr08/osal that referenced this issue Jun 9, 2021
@jphickey @pepepr08
Fix nasa#1008, resolve discrepancies between binsem API and unit tests
d71f64a 
Ensures correlation between the unit-tests and documented return
values for the OSAL binsem API.
@skliper skliper mentioned this issue Jun 29, 2021
Closed
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1008 from nasa/integration-candidate
32f3dee 
Integration Candidate: 2020-11-10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper