Fix #2543, consistent TIME values for TBL structures #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the CFE_TIME_SysTime_t type more consistently across TBL where time is being stored. Avoid using seconds/subseconds directly. This also adds an initializer value for CFE_TIME_SysTime_t that has seconds/subseconds as zero.
jphickey
force-pushed
the
fix-2543-tbl-time
branch
from
fa9f55f
to
32cc4d0
Compare
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 5, 2024
*Combines:* cFE equuleus-rc1+dev127 **Includes:** *cFE* - nasa/cFE#2541 - nasa/cFE#2544 Co-authored by: Drew Paettie <cazlo@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Apr 5, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 5, 2024
*Combines:* cFE equuleus-rc1+dev127 **Includes:** *cFE* - nasa/cFE#2541 - nasa/cFE#2544 Co-authored by: Drew Paettie <cazlo@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Use the CFE_TIME_SysTime_t type more consistently across TBL where time is being stored. Avoid using seconds/subseconds directly.
This also adds an initializer value for CFE_TIME_SysTime_t that has seconds/subseconds as zero.
Fixes #2543
Testing performed
Build and sanity check CFE, run all tests and workflows
Expected behavior changes
In general, nothing -- but some external tools might get tripped on the fact that the two uint32 values in TLM is now a sub-struct (CFE_TIME_SysTime_t) instead of being expressed directly as 2 uint32 values.
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.