Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent time definition for TBL subsystem data structures #2543

Closed
jphickey opened this issue Apr 3, 2024 · 0 comments · Fixed by #2544
Closed

Use consistent time definition for TBL subsystem data structures #2543

jphickey opened this issue Apr 3, 2024 · 0 comments · Fixed by #2544
Assignees

Comments

@jphickey
Copy link
Contributor

jphickey commented Apr 3, 2024

Is your feature request related to a problem? Please describe.
Currently the TBL data structures use a mixture of TIME representations. In some cases it uses the CFE_TIME_SysTime_t value, and in other cases it uses two uint32 values.

Describe the solution you'd like
Use the CFE_TIME_SysTime_t representation of time consistently.

Describe alternatives you've considered
N/A

Additional context
Consistent use of the same data type for TIME representation allows data to be exchanged more easily and simplifies the code. The CFE_TIME_SysTime_t has getters and macros that support and simplify use of this type. These should be leveraged/used in TBL rather than repeating the logic.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Apr 3, 2024
jphickey added a commit to jphickey/cFE that referenced this issue Apr 3, 2024
Use the CFE_TIME_SysTime_t type more consistently across TBL where
time is being stored.  Avoid using seconds/subseconds directly.

This also adds an initializer value for CFE_TIME_SysTime_t that
has seconds/subseconds as zero.
dzbaker added a commit that referenced this issue Apr 5, 2024
Fix #2543, consistent TIME values for TBL structures
@dzbaker dzbaker closed this as completed in 32cc4d0 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant