Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1901, remove else statement that was unreachable by unit tests #2303

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Fix #1901, remove else statement that was unreachable by unit tests #2303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions modules/tbl/fsw/inc/cfe_tbl_events.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,18 +345,6 @@
*/
#define CFE_TBL_NO_WORK_BUFFERS_ERR_EID 60

/**
* \brief TBL Load Table Command Get Working Buffer Internal Failure Event ID
*
* \par Type: ERROR
*
* \par Cause:
*
* \link #CFE_TBL_LOAD_CC TBL Load Table Command \endlink failure due to
* internal get working buffer error.
*/
#define CFE_TBL_INTERNAL_ERROR_ERR_EID 61

/**
* \brief TBL Write File Creation Failure Event ID
*
Expand Down
7 changes: 1 addition & 6 deletions modules/tbl/fsw/src/cfe_tbl_task_cmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,16 +475,11 @@ int32 CFE_TBL_LoadCmd(const CFE_TBL_LoadCmd_t *data)
TblFileHeader.TableName);
}
}
else if (Status == CFE_TBL_ERR_NO_BUFFER_AVAIL)
else
{
CFE_EVS_SendEvent(CFE_TBL_NO_WORK_BUFFERS_ERR_EID, CFE_EVS_EventType_ERROR,
"No working buffers available for table '%s'", TblFileHeader.TableName);
}
else
{
CFE_EVS_SendEvent(CFE_TBL_INTERNAL_ERROR_ERR_EID, CFE_EVS_EventType_ERROR,
"Internal Error (Status=0x%08X)", (unsigned int)Status);
}
}
else
{
Expand Down