Fix #1901, remove else statement that was unreachable by unit tests #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
reviewed
Apr 24, 2023
|
@skliper Good catch! Do you think I should move up all of the event id numbers? |
|
@havencarlson - I've typically just left the gap, those numbers are cheap :) |
havencarlson
force-pushed
the
issue-1901
branch
from
08df3f8
to
972f76a
Compare
dzbaker
added
the
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 28, 2023
*Combines:* cFE v7.0.0-rc4+dev287 **Includes:** *cFE* - nasa/cFE#2306 - nasa/cFE#2295 - nasa/cFE#2303 - nasa/cFE#2312 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
This was referenced Apr 28, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 28, 2023
*Combines:* cFE v7.0.0-rc4+dev287 **Includes:** *cFE* - nasa/cFE#2306 - nasa/cFE#2295 - nasa/cFE#2303 - nasa/cFE#2312 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #1901.
CFE_TBL_GetWorkingBuffer()could only ever returnCFE_SUCCESSorCFE_TBL_ERR_NO_BUFFER_AVAIL. Removed else statement that would never be able to be reached.Testing performed
Unit tests
Expected behavior changes
No impact to behavior
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA