Fix #87, Change EVS_Register failure from SendEvent to WriteToSysLog #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
requested changes
Mar 16, 2023
unit-test/fm_app_tests.c
Outdated
|
|
||
| call_count_CFE_EVS_SendEvent = UT_GetStubCount(UT_KEY(CFE_EVS_SendEvent)); | ||
| UtAssert_True(call_count_CFE_EVS_SendEvent == 0, "CFE_EVS_SendEvent was called %u time(s), expected 0", | ||
| call_count_CFE_EVS_SendEvent); |
There was a problem hiding this comment.
I would recommend taking out these two assertions, no real need to assert that a function was not called. Also no need to add the global variable either.
There was a problem hiding this comment.
No worries @jphickey
Removed those two.
thnkslprpt
force-pushed
the
fix-87-change-EVS_Register-failure-to-WriteToSysLog
branch
3 times, most recently
from
1774fa5
to
24042f1
Compare
thnkslprpt
force-pushed
the
fix-87-change-EVS_Register-failure-to-WriteToSysLog
branch
from
24042f1
to
9d5d771
Compare
thnkslprpt
deleted the
fix-87-change-EVS_Register-failure-to-WriteToSysLog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #87
CFE_EVS_SendEventreplaced byCFE_ES_WriteToSysLogon failure ofCFE_EVS_Register.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Coverage maintained at 100%:
Expected behavior changes
Failure can be successfully recorded somewhere even without the EVS now.
Contributor Info
Avi Weiss @thnkslprpt