Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM tries to send an event message on failure of registering with EVS #87

Closed
2 tasks done
thnkslprpt opened this issue Mar 4, 2023 · 0 comments · Fixed by #88
Closed
2 tasks done

FM tries to send an event message on failure of registering with EVS #87

thnkslprpt opened this issue Mar 4, 2023 · 0 comments · Fixed by #88

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Copy of nasa/DS#85
FM and DS are the only apps to (attempt to) utilize CFE_EVS_SendEvent even though the call to CFE_EVS_Register failed.
Better update to CFE_ES_WriteToSysLog so failure can be recorded somewhere. This brings FM (and DS) in line with the other cFS apps.

Code snips

FM/fsw/src/fm_app.c

Lines 175 to 182 in 2be3511

/* Register for event services */
Result = CFE_EVS_Register(NULL, 0, CFE_EVS_EventFilter_BINARY);
if (Result != CFE_SUCCESS)
{
CFE_EVS_SendEvent(FM_STARTUP_EVENTS_ERR_EID, CFE_EVS_EventType_ERROR,
"%s register for event services: result = 0x%08X", ErrText, (unsigned int)Result);
}

Expected behavior
CFE_ES_WriteToSysLog on failure.

Reporter Info
Avi Weiss @thnkslprpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants