Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #84, Remove superfluous assignments at the top of functions #85

Closed

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution
Fixes #84
Extraneous assignments at the top of functions were removed.
Code is cleaner, and future maintainability is improved.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No change to behavior.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-84-remove-superfluous-assignments branch 2 times, most recently from b782e46 to 7368127 Compare March 12, 2023 12:20
@thnkslprpt thnkslprpt force-pushed the fix-84-remove-superfluous-assignments branch from 7368127 to bc09c69 Compare March 14, 2023 12:51
@dzbaker dzbaker requested a review from chillfig March 16, 2023 18:39
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dzbaker dzbaker closed this in #88 Mar 30, 2023
@thnkslprpt
Copy link
Contributor Author

@dzbaker - do you know what happened with this by any chance?
Cheers

@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superfluous assignments at the top of functions
3 participants