Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Re enable and Ruff's ARG check globally #441

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Refactor: Re enable and Ruff's ARG check globally #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion narwhals/_pandas_like/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def iter_rows(
self,
*,
named: bool = False,
buffer_size: int = 512,
buffer_size: int = 512, # noqa: ARG002
) -> Iterator[list[tuple[Any, ...]]] | Iterator[list[dict[str, Any]]]:
"""
NOTE:
Expand Down
2 changes: 1 addition & 1 deletion narwhals/_pandas_like/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ def is_sorted(self: Self, *, descending: bool = False) -> bool:
else:
return self._native_series.is_monotonic_increasing # type: ignore[no-any-return]

def value_counts(self: Self, *, sort: bool = False, parallel: bool = False) -> Any:
def value_counts(self: Self, *, sort: bool = False, parallel: bool = False) -> Any: # noqa: ARG002
"""Parallel is unused, exists for compatibility"""
from narwhals._pandas_like.dataframe import PandasDataFrame

Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ lint.ignore = [
'A003',
'ANN101',
'ANN401',
'ARG002', # todo: enable
'ARG003', # todo: enable
'C901',
'COM812',
'D',
Expand Down
Loading