Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Re enable and Ruff's ARG check globally #441

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ELC
Copy link
Contributor

@ELC ELC commented Jul 9, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

The idea of this PR is to locally disable the check where it cannot be avoided and enable it globally to make sure new violations are properly flagged

@ELC ELC changed the title Refactor: Re enable and fix ARG checks Refactor: Re enable and Ruff's ARG check globally Jul 9, 2024
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! We can merge this right away!

JackSparrowCatWinkGIF

@MarcoGorelli
Copy link
Member

thanks both!

@MarcoGorelli MarcoGorelli merged commit 825988a into narwhals-dev:main Jul 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants