Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude pyqt from installers #31

Open
jaimergp opened this issue Sep 8, 2022 · 5 comments
Open

Exclude pyqt from installers #31

jaimergp opened this issue Sep 8, 2022 · 5 comments
Labels
bundle ci Continuous infrastructure

Comments

@jaimergp
Copy link
Collaborator

jaimergp commented Sep 8, 2022

Pending new version of constructor, which provides solver-less installs thanks to conda/constructor#559

@jaimergp
Copy link
Collaborator Author

jaimergp commented Sep 14, 2022

Even if we will remove pyqt from the installation, a plugin might still bring it back if it directly depends on it, or a dependency does. We have setup a CI pipeline to analyse potential cases like this, and we are finding a few.

I'll be collecting them here, along with the relevant issues and PRs fixing it.

@psobolewskiPhD
Copy link
Member

@jaimergp another thing to check for might be depending on napari[all] since this also pulls in PyQt.
See for example PlatyMatch: juglab/PlatyMatch#7

@jaimergp
Copy link
Collaborator Author

jaimergp commented Oct 3, 2022

Thanks @psobolewskiPhD! I checked the conda-forge recipe and it doesn't suffer from that issue, since there's no napari[all] option in conda, just napari, so we are covered in this case!

@psobolewskiPhD
Copy link
Member

Oh good.
Alas that specific one does have a from PyQt5.QtCore import Qt as well.
Hopefully the devs take a look at my PR.

@jaimergp
Copy link
Collaborator Author

jaimergp commented Oct 3, 2022

Oh I had missed the PR content! Good catch! So far the experimental CI doesn't check the source content. I think we could talk with the napari-hub team to set some kind of static code analysis though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundle ci Continuous infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants