Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit dependency on PyQt5 #1

Open
jaimergp opened this issue Sep 14, 2022 · 0 comments · May be fixed by #2
Open

Explicit dependency on PyQt5 #1

jaimergp opened this issue Sep 14, 2022 · 0 comments · May be fixed by #2

Comments

@jaimergp
Copy link

Hello team!

The plugin documentation for napari has a set of best practices for developers, which includes a clause recommending not to depend directly on PyQt5 or PySide2 to allow end-users to choose their bindings freely. More details here.

Is there a reason you need PyQt5 explicitly or is this more of an oversight? Code search didn't reveal any relevant imports either.

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use qtpy instead of PyQt directly jaimergp/iacs_ipac_reader
1 participant
@jaimergp