Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package is using PyQt5 imports instead of qtpy #39

Closed
goanpeca opened this issue Oct 24, 2022 · 2 comments
Closed

Package is using PyQt5 imports instead of qtpy #39

goanpeca opened this issue Oct 24, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@goanpeca
Copy link
Contributor

Hello team!

The plugin documentation for napari has a set of best practices for developers, which includes a clause recommending not to depend directly on PyQt5 or PySide2 to allow end-users to choose their bindings freely. More details here.

The files using PyQt5 instead of qtpy -> https://github.com/bauerdavid/napari-nD-annotator/search?q=pyqt5

Is there a reason you need PyQt5 explicitly? Could these imports be updated to use qtpy for the next release?

Thanks!

@goanpeca goanpeca added the bug Something isn't working label Oct 24, 2022
@bauerdavid
Copy link
Owner

This is an error indeed, qtpy should be used. Thanks for pointing that out! Fixed in 128cd09.

@goanpeca
Copy link
Contributor Author

Thanks for the fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants