Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI command for better LMDB compaction #2435

Merged
merged 4 commits into from
Dec 17, 2019
Merged

Add CLI command for better LMDB compaction #2435

merged 4 commits into from
Dec 17, 2019

Conversation

SergiySW
Copy link
Contributor

No description provided.

@SergiySW SergiySW added the database Relates to lmdb or rocksdb label Dec 11, 2019
@SergiySW SergiySW added this to the V21.0 milestone Dec 11, 2019
@SergiySW SergiySW self-assigned this Dec 11, 2019
wezrule
wezrule previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@wezrule wezrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start ledger size: 15.6GB
Max size during vacuum: 30GB
Final ledger size: 11.3GB

Took between 20-30 minutes on Windows, I didn't catch the exact time.

@cryptocode cryptocode added the documentation This item indicates the need for or supplies updated or expanded documentation label Dec 11, 2019
cryptocode
cryptocode previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending doc issue or pr / CI formatting

@SergiySW SergiySW dismissed stale reviews from cryptocode and wezrule via af3cdeb December 12, 2019 11:02
@SergiySW SergiySW mentioned this pull request Dec 12, 2019
Merged
@SergiySW SergiySW merged commit 8e6cde7 into nanocurrency:develop Dec 17, 2019
@guilhermelawless guilhermelawless mentioned this pull request Jan 31, 2020
Closed
@guilhermelawless guilhermelawless mentioned this pull request Feb 10, 2020
Merged
@zhyatt zhyatt added the cli Changes related to the Command Line Interface label Apr 22, 2020
SergiySW added a commit to nanocurrency/nano-docs that referenced this pull request May 15, 2020
@SergiySW
Add CLI command for better LMDB compaction (#193)
e37a9e5 
* Add CLI command for better LMDB compaction
Docs change for nanocurrency/nano-node#2435
* More --vacuum details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
cli Changes related to the Command Line Interface database Relates to lmdb or rocksdb documentation This item indicates the need for or supplies updated or expanded documentation
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @wezrule @cryptocode @zhyatt