Add CLI command for better LMDB compaction #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
reviewed
Dec 12, 2019
zhyatt
reviewed
Dec 12, 2019
| @@ -131,6 +134,7 @@ Clear unchecked blocks | |||
|
|
|||
| ### --vacuum | |||
| Compact database. If data_path is missing, the database in data directory is compacted. Optional `--unchecked_clear`, `--clear_send_ids`, `--online_weight_clear`, `--peer_clear` | |||
| Optional `--rebuild_database` in version 21.0+ | |||
There was a problem hiding this comment.
Do we need to call out the *2 disk space here as well?
There was a problem hiding this comment.
Should this be mentioned on --snapshot section as well? Also --confirmation_height_clear should probably be mentioned in vacuum too.
There was a problem hiding this comment.
Why mention this in --snapshot?
Closed
|
@SergiySW Are there additional details you need on the feedback above? |
zhyatt
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs change for nanocurrency/nano-node#2435