Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node telemetry #231

Merged
merged 16 commits into from
Apr 22, 2020
Merged

Node telemetry #231

merged 16 commits into from
Apr 22, 2020

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Feb 14, 2020

Closes #219

@zhyatt zhyatt added this to the V21.0 milestone Feb 14, 2020
docs/commands/rpc-protocol.md Outdated Show resolved Hide resolved
docs/commands/rpc-protocol.md Outdated Show resolved Hide resolved
@wezrule
Copy link
Contributor Author

wezrule commented Mar 20, 2020

Websockets and signature/node_id need to be accounted for

docs/commands/rpc-protocol.md Outdated Show resolved Hide resolved
docs/commands/rpc-protocol.md Outdated Show resolved Hide resolved
@zhyatt
Copy link
Contributor

zhyatt commented Apr 20, 2020

@wezrule @guilhermelawless Just want to draw attention to the questions outlined here as they may impact what documentation is included: nanocurrency/nano-node#2726 (comment)

Some of these are lower level than we typically include in our docs, but perhaps we should have an area for more advanced understanding of telemetry? Thoughts?

@guilhermelawless
Copy link
Contributor

We have an open issue on our protocol repository: nanocurrency/protocol#9 . If we don't want the full information in nano-docs, we could use that one for the most technical details about the protocol, perhaps moving to the living whitepaper in the future?

@zhyatt
Copy link
Contributor

zhyatt commented Apr 20, 2020

Good call, I think some sharing of details between the two makes sense, although that protocol repository is quite constrained on the info that can be included, given it all exists in the Kaitai spec/image. If extra context is needed to be captured now outside that spec, perhaps we can put a new section in https://docs.nano.org/protocol-design/networking/ and then transfer to the living whitepaper later.

Copy link
Contributor

@guilhermelawless guilhermelawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few small corrections

docs/protocol-design/networking.md Outdated Show resolved Hide resolved
docs/protocol-design/networking.md Outdated Show resolved Hide resolved
docs/protocol-design/networking.md Outdated Show resolved Hide resolved
wezrule and others added 3 commits April 22, 2020 12:44
Co-Authored-By: Guilherme Lawless <guilherme.lawless@gmail.com>
Co-Authored-By: Guilherme Lawless <guilherme.lawless@gmail.com>
docs/commands/rpc-protocol.md Outdated Show resolved Hide resolved
docs/commands/rpc-protocol.md Outdated Show resolved Hide resolved
docs/protocol-design/networking.md Outdated Show resolved Hide resolved
wezrule and others added 3 commits April 22, 2020 14:37
Co-Authored-By: Guilherme Lawless <guilherme.lawless@gmail.com>
Co-Authored-By: Guilherme Lawless <guilherme.lawless@gmail.com>
Co-Authored-By: Guilherme Lawless <guilherme.lawless@gmail.com>
docs/commands/rpc-protocol.md Outdated Show resolved Hide resolved
docs/protocol-design/networking.md Outdated Show resolved Hide resolved
@wezrule wezrule merged commit 8197f93 into nanocurrency:master Apr 22, 2020
@wezrule wezrule deleted the node_telemetry branch April 22, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Node Telemetry details
3 participants