Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry to protocol specification #9

Closed
cryptocode opened this issue Jan 29, 2020 · 4 comments
Closed

Add telemetry to protocol specification #9

cryptocode opened this issue Jan 29, 2020 · 4 comments
Assignees

Comments

@cryptocode
Copy link
Contributor

nanocurrency/nano-node#2446

@wezrule
Copy link
Contributor

wezrule commented Feb 20, 2020

telemetry_req
No payload

telemetry_ack
header.extensions contains the size of the telemetry data payload.

64 block_count
64 cemented_count
64 unchecked_count
64 account_count
64 bandwidth_cap
64 uptime
32 peer_count
8 protocol_version
256 genesis_block
8 major_version
8 minor_version
8 patch_version
8 pre_release_version
8 maker
64 timestamp

@inkeliz
Copy link

inkeliz commented Apr 29, 2020

I think it should specify the type, not jus the size.

For comparation:

vote_common:
doc: Common data shared by block votes and vote-by-hash votes
seq:
- id: account
size: 32
- id: signature
size: 64
- id: sequence
type: u8le

msg_telemetry_ack:
doc: Signed telemetry response
seq:
- id: signature
size: 256
doc: Signature
- id: nodeid
size: 256
doc: Public node id
- id: blockcount
size: 64
doc: Block count
- id: cementedcount
size: 64
doc: Cemented block count
- id: uncheckedcount
size: 64
doc: Unchecked block count
- id: accountcount
size: 64
doc: Account count
- id: bandwidthcap
size: 64
doc: Bandwidth limit, 0 indiciates unlimited
- id: uptime
size: 64
doc: Length of time a peer has been running for (in seconds)
- id: peercount
size: 32

I think blockcount, for instance, is an uint64le, but it's not specified. I think it should be like the vote_common, with type: u8le.

@zhyatt zhyatt reopened this Apr 29, 2020
@wezrule
Copy link
Contributor

wezrule commented Apr 30, 2020

@inkeliz

Makes sense, thanks. https://github.com/nanocurrency/protocol/pull/12/files. In case it affects any testing, we have also modified the data so be consistent, it is all big endian now.

@zhyatt
Copy link
Collaborator

zhyatt commented Mar 2, 2021

Fixed in #12

@zhyatt zhyatt closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants