ci: Prevent e2e failure on commented type review (no-changelog)
#6452
Conversation
|
could we instead have the CI workflow not even start until the PR is approved, instead of starting, and then skipping it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6452 +/- ##
==========================================
- Coverage 28.37% 28.37% -0.01%
==========================================
Files 2991 2991
Lines 185889 185952 +63
Branches 20474 20504 +30
==========================================
+ Hits 52742 52757 +15
- Misses 132355 132401 +46
- Partials 792 794 +2
☔ View full report in Codecov by Sentry. |
I also found it odd why we do this, but seeing the below PRs, this might be needed. Maybe @OlegIvaniv knows better? |
GH actions do not support approved as activity type for |
1 flaky tests on run #1220 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > can pair items between input and output across branches and runs |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
* master: (34 commits) feat(editor): Replace root events with event bus events (no-changelog) (#6454) feat(DebugHelper Node): Fix and include in main app (#6406) feat(Webhook Node): Stream binary response in `lastNode.firstEntryBinary` mode (#6463) fix(editor): Update git repo URL validation to prevent using https protocol (#6475) fix(editor): Remove tooltip about SMTP being required to invite user (no-changelog) (#6474) feat: Add support for large files with declarative nodes (#6461) fix(core): Fix the url sent in the password-reset emails (#6466) fix(HTML Node): Prevent XSS in execution-data preview (#6432) fix(Snowflake Node): Upgrade snowflake-sdk to address CVE-2023-34232 (no-changelog) (#6458) refactor(core): Replace lodash's "soft-deprecated" individual packages with `lodash` to resolve CVE (no-changelog) (#6450) fix(editor): Remove `$if`, `$min` and `$max` from code node autocomplete (#6460) fix(editor): Fix DNV header disappearing when scrolling the code editor content (#6459) feat: Remove vue-fragment (no-changelog) (#6456) ci: Prevent e2e failure on `commented` type review (no-changelog) (#6452) fix(LinkedIn Node): Remove unsupported description from image posts (#6446) fix(Split In Batches Node): Add "done" context to allow simple reset (#6437) feat(Gmail Node): Add reply to email (#6453) fix: Remove Vue.component usage and refactor plugins into Vue Plugins (no-changelog) (#6445) fix(editor): Show confirm on pull only when http response status is 409 (#6451) fix(editor): Update data pinning tooltip to match current behaviour (#6436) ... # Conflicts: # packages/nodes-base/nodes/CompareDatasets/GenericFunctions.ts # packages/nodes-base/nodes/Merge/v2/GenericFunctions.ts
|
Got released with |
No description provided.