ci: Debug e2e pipeline (no-changelog) #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
mutdmour
approved these changes
May 12, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6240 +/- ##
=======================================
Coverage 27.62% 27.62%
=======================================
Files 2937 2937
Lines 180136 180136
Branches 19549 19549
=======================================
Hits 49764 49764
Misses 129641 129641
Partials 731 731 ☔ View full report in Codecov by Sentry. |
|
|
OlegIvaniv
changed the title
netroy
approved these changes
May 12, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 16, 2023
* master: (22 commits) fix: Remove workflow execution credential error message when instance owner (#6116) refactor(editor): Drop vue-typed-mixins (no-changelog) (#6257) feat(core): Return OAuth2 error body if available (#5794) fix: Add itemSize config to workflows view recycle scroller (no-changelog) (#6238) fix(editor): Fix close and cancel operations on useMessage (no-changelog) (#6260) feat(editor): Add cloud ExecutionsUsage and API blocking using licenses (#6159) refactor(editor): Turn showMessage mixin to composable (#6081) (#6244) feat(core): Add experimental proxy support to License-SDK (no-changelog) (#6253) feat(core): Reduce the number of events sent to Sentry (#6235) feat(editor): Drop support for legacy browsers that do not have native ESM support (#6239) refactor(editor): Add missing interface IUserListAction (no-changelog) (#6241) ci: Debug e2e pipeline (no-changelog) (#6240) Revert "refactor(editor): Turn showMessage mixin to composable" (#6243) feat(editor): Updating node reference pattern in expression editor (#6228) refactor(editor): Remove unused dependencies (no-changelog) (#6223) refactor(editor): Turn showMessage mixin to composable (#6081) feat(editor): Version Control settings update (WIP) (#6233) ci: Fix linting issue on master (no-changelog) (#6232) fix: Prevent type error messages for manual executions (no-changelog) (#6229) fix(Code Node): Restore help text (#6231) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed instances where the
post-e2e-testsworkflow was passing even when therun-e2e-testsjob did not execute. This anomaly allowed PRs to be merged without a successful e2e pipeline, which is not the intended behavior. The problem was due to theif: always()condition in thepost-e2e-testsjob, which executed it following anypull_request_reviewevent (for example, when changes were requested).To rectify this issue, we have implemented an additional condition,
github.event.review.state != 'approved'to the fail job. This condition ensures that the required checks will consistently fail if the PR is not approved, thus preventing untested merges.