Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add endpoint to create free AI credits #12362

Open
wants to merge 4 commits into
base: refactor-credential-creation-endpoint
Choose a base branch
from

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 24, 2024

Summary

Builds on top of #12361

See context in the linear ticket below.

  • Introduce new endpoint to create free AI credits managed credential.
  • Make sure managed credentials cannot be edited.
  • Make sure to return the isManaged flag to the FE. We will need to this to hide the fields in the credentials modal.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2998/[n8n-backend]-add-new-endpoint-to-save-managed-credentials

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title ado 2998 n8n backend add new endpoint to save managed credentials feat(core): Add endpoint to create free AI credits Dec 24, 2024
@RicardoE105 RicardoE105 changed the base branch from master to refactor-credential-creation-endpoint December 24, 2024 17:10
@RicardoE105 RicardoE105 requested a review from mutdmour December 24, 2024 17:12
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/services/ai.service.ts 0.00% 5 Missing ⚠️
packages/cli/src/controllers/ai.controller.ts 75.00% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

also validates that managed credentials cannot be edited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant