refactor(core): Encapsulate logic to create new credential into its own method #12361
+26
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
RicardoE105
changed the title
n8n-assistant
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prep work to be able to add a new endpoint to create manage credentials. Context in the linear ticket below
We already have tests for this endpoint here ->
n8n/packages/cli/test/integration/credentials/credentials.api.test.ts
Line 590 in f754b22
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2998/[n8n-backend]-add-new-endpoint-to-save-managed-credentials
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)