Deploy new styles to main #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got storybook up and running again and added buttons from Dylan's designs here: https://app.zeplin.io/project/61327f6d0e26559ad2dce006/styleguide/components?coid=614815f025df846adc8b71c1 You can see storybook by running `npm run storybook`
thisss is the magic
Part of the new note component, from https://zpl.io/VxqZn3w
this required me to implement the search input
Storybook stories
Add this in a story. We may want to push this down into the NewNote modal
Make this look and feel great using the example at https://tailwindui.com/components/application-ui/overlays/modals
Modal, a play in 3 acts
Apparently slate nodes don't always have a type, even if they have children. So just recursive if you find a child key even if there is no type.
The whole library is very large. Eventually we should get rid of this, and replace with our own SVG icons, but for now these are still needed for the editor toolbars / bubble menus.
Fixed bug in Slate converter
Only load the styled-icons libraries we need
if a user seems logged in but is unable to access the private workspace, automatically log them out. needs lots of testing
Better to clean this up soon, but I wanna ship!
Clean up note lists
still need to implement save
Header Tweaks
New note modal
I spent a few hours trying to use Formik here, but the validation/save pattern is a little wonky thanks to all the hooks. Let's do this for now and fix later!
Port save logic to NewNote modal
Also realized that useCombinedConceptIndex no longer works as it relied on the assumption that a SolidDataset was an RDF dataset, which is no longer true!
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/DG5o9ifmWkVNB2kTVCuscSfC9wEb |
Two problems: 1) and more seriously, when you hit the browser's "back" button the concept would change but the note body would not, so autosave would save the previous note's body to the concept you were looking at. Fix this by using a different editor ID for every note. 2) Empty notes were broken - not loading when you went directly to them, and saving the previous note's body if you clicked through from an existing note to one that didn't exist yet. Fix this and add a basic UI to let people create notes through this flow.
Solid world polish
Clickable Garden Map Demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening the PR, sounds like it's not ready to merge yet.