Solid world polish #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also realized that useCombinedConceptIndex no longer works as it relied on the assumption that a SolidDataset was an RDF dataset, which is no longer true!
Two problems: 1) and more seriously, when you hit the browser's "back" button the concept would change but the note body would not, so autosave would save the previous note's body to the concept you were looking at. Fix this by using a different editor ID for every note. 2) Empty notes were broken - not loading when you went directly to them, and saving the previous note's body if you clicked through from an existing note to one that didn't exist yet. Fix this and add a basic UI to let people create notes through this flow.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/CJBrUFUTP6Sw8fj8aYdMCZZXz6Jb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.