Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): always execute module installation on upgrade #271

Merged
merged 7 commits into from
Nov 13, 2024

fix: clean up entry file and remove created upgrade file after upgrading

ec77556
Select commit
Loading
Failed to load commit list.
Merged

fix(upgrade): always execute module installation on upgrade #271

fix: clean up entry file and remove created upgrade file after upgrading
ec77556
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

48.15% (-0.01%) compared to 165c91b

View this Pull Request on Codecov

48.15% (-0.01%) compared to 165c91b

Details

Codecov Report

Attention: Patch coverage is 64.62585% with 52 lines in your changes missing coverage. Please review.

Project coverage is 48.15%. Comparing base (165c91b) to head (ec77556).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Hooks/HasModuleUpgradeOverrides.php 35.41% 31 Missing ⚠️
src/Database/AbstractDatabaseMigration.php 59.45% 15 Missing ⚠️
src/Database/CreateAuditTableDatabaseMigration.php 92.85% 1 Missing ⚠️
...ase/CreateCarrierMappingTableDatabaseMigration.php 87.50% 1 Missing ⚠️
...reateCartDeliveryOptionsTableDatabaseMigration.php 85.71% 1 Missing ⚠️
...Database/CreateOrderDataTableDatabaseMigration.php 87.50% 1 Missing ⚠️
...base/CreateOrderShipmentTableDatabaseMigration.php 90.90% 1 Missing ⚠️
...se/CreateProductSettingsTableDatabaseMigration.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #271      +/-   ##
============================================
- Coverage     48.15%   48.15%   -0.01%     
- Complexity      561      578      +17     
============================================
  Files           148      149       +1     
  Lines          3721     3802      +81     
  Branches         55       55              
============================================
+ Hits           1792     1831      +39     
- Misses         1874     1916      +42     
  Partials         55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.