Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): always execute module installation on upgrade #271

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

EdieLemoine
Copy link
Contributor

No description provided.

@EdieLemoine EdieLemoine requested a review from a team as a code owner August 16, 2024 11:53
@EdieLemoine EdieLemoine force-pushed the fix/upgrade-install-always branch from ec962a3 to 99a6283 Compare August 16, 2024 11:53
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Aug 16, 2024

PDK upgrade summary

The following packages were upgraded:

Package Old version New version
myparcelnl/pdk 2.42.0 2.43.4

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 64.62585% with 52 lines in your changes missing coverage. Please review.

Project coverage is 48.15%. Comparing base (165c91b) to head (ec77556).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Hooks/HasModuleUpgradeOverrides.php 35.41% 31 Missing ⚠️
src/Database/AbstractDatabaseMigration.php 59.45% 15 Missing ⚠️
src/Database/CreateAuditTableDatabaseMigration.php 92.85% 1 Missing ⚠️
...ase/CreateCarrierMappingTableDatabaseMigration.php 87.50% 1 Missing ⚠️
...reateCartDeliveryOptionsTableDatabaseMigration.php 85.71% 1 Missing ⚠️
...Database/CreateOrderDataTableDatabaseMigration.php 87.50% 1 Missing ⚠️
...base/CreateOrderShipmentTableDatabaseMigration.php 90.90% 1 Missing ⚠️
...se/CreateProductSettingsTableDatabaseMigration.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #271      +/-   ##
============================================
- Coverage     51.96%   48.15%   -3.81%     
+ Complexity      690      578     -112     
============================================
  Files           152      149       -3     
  Lines          4191     3802     -389     
  Branches         55       55              
============================================
- Hits           2178     1831     -347     
+ Misses         1958     1916      -42     
  Partials         55       55              
Flag Coverage Δ
backend 76.00% <64.62%> (-2.03%) ⬇️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch from 47278db to d8b8581 Compare August 16, 2024 13:36
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Aug 16, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit ec77556
Logs https://github.com/myparcelnl/prestashop/actions/runs/11724472064
Download https://github.com/myparcelnl/prestashop/suites/30617798799/artifacts/2157942017

@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch 4 times, most recently from ee63de3 to 890e863 Compare September 26, 2024 14:03
@myparcel-bot myparcel-bot bot added the approved (Auto) label Sep 27, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch 4 times, most recently from 3168331 to dabbf0c Compare October 4, 2024 11:24
@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch 12 times, most recently from 593f256 to d45c61a Compare October 9, 2024 15:24
@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch 5 times, most recently from 63f02e0 to eac0593 Compare October 16, 2024 10:35
@EdieLemoine EdieLemoine changed the base branch from beta to main October 16, 2024 11:35
@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch from cae07fc to 6d1e8aa Compare October 16, 2024 11:53
@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch 4 times, most recently from 39f603b to 67f1439 Compare October 24, 2024 13:30
@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch 3 times, most recently from 53d0e7d to 22d5465 Compare October 30, 2024 18:08
@myparcel-bot myparcel-bot bot force-pushed the fix/upgrade-install-always branch from 22d5465 to ec77556 Compare November 7, 2024 13:58
@EdieLemoine EdieLemoine added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 78b3657 Nov 13, 2024
6 checks passed
@EdieLemoine EdieLemoine deleted the fix/upgrade-install-always branch November 13, 2024 13:18
myparcel-bot bot added a commit that referenced this pull request Nov 20, 2024
## [4.2.0](v4.1.0...v4.2.0) (2024-11-20)

### 🐛 Bug Fixes

* **admin:** fix toggle and tristate input elements not working correctly ([#278](#278)) ([c8832fd](c8832fd)), closes [myparcelnl/js-pdk#223](myparcelnl/js-pdk#223)
* **orders:** export correct recipient name ([#277](#277)) ([883dcf4](883dcf4)), closes [#276](#276)
* **upgrade:** always execute module installation on upgrade ([#271](#271)) ([78b3657](78b3657))

### ✨ New Features

* **backend:** add download logs action ([#275](#275)) ([7bb1349](7bb1349)), closes [myparcelnl/pdk#288](myparcelnl/pdk#288) [myparcelnl/js-pdk#221](myparcelnl/js-pdk#221)
* **checkout:** show carriers only for countries they ship to ([#273](#273)) ([e13b6a2](e13b6a2))
* **deps:** upgrade @myparcel-pdk/checkout to v1.2.0 ([0b314e9](0b314e9))
* **deps:** upgrade myparcelnl/pdk to v2.47.1 ([ffe8ce4](ffe8ce4))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 20, 2024

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants