Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix non-default package types not working #216

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

EdieLemoine
Copy link
Contributor

INT-447

@EdieLemoine EdieLemoine requested a review from a team as a code owner April 15, 2024 13:18
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit b3ba5a0
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/661d35e09d1b3100083a5019
😎 Deploy Preview https://deploy-preview-216--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.08%. Comparing base (559a830) to head (b3ba5a0).

Files Patch % Lines
...ptions/src/composables/useDeliveryMomentOptions.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   79.56%   80.08%   +0.52%     
==========================================
  Files         354      354              
  Lines       11100    11099       -1     
  Branches      446      465      +19     
==========================================
+ Hits         8832     8889      +57     
+ Misses       1828     1752      -76     
- Partials      440      458      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot added the approved (Auto) label Apr 15, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/package-types-error branch from 3771d70 to b3ba5a0 Compare April 15, 2024 14:12
@EdieLemoine EdieLemoine requested a review from a team as a code owner April 15, 2024 14:12
@EdieLemoine EdieLemoine enabled auto-merge April 15, 2024 14:13
@EdieLemoine EdieLemoine added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 1fb7b7c Apr 15, 2024
8 of 9 checks passed
@EdieLemoine EdieLemoine deleted the fix/package-types-error branch April 15, 2024 14:15
myparcel-bot bot added a commit that referenced this pull request Apr 15, 2024
## [@myparcel/delivery-options-v6.1.0](v6.0.2...v6.1.0) (2024-04-15)

### ✨ New Features

* **design:** add styling to errors ([a143d55](a143d55))

### 🐛 Bug Fixes

* expose validated config on window object ([#215](#215)) ([d717532](d717532))
* fix non-default package types not working ([#216](#216)) ([1fb7b7c](1fb7b7c))
* select standard delivery initially ([#214](#214)) ([0e67095](0e67095))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Apr 15, 2024

🎉 This PR is included in version @myparcel/delivery-options-v6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants