Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose validated config on window object #215

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

EdieLemoine
Copy link
Contributor

No description provided.

@EdieLemoine EdieLemoine requested a review from a team as a code owner April 5, 2024 13:04
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.99%. Comparing base (559a830) to head (7a756fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   79.56%   79.99%   +0.42%     
==========================================
  Files         354      354              
  Lines       11100    11102       +2     
  Branches      446      554     +108     
==========================================
+ Hits         8832     8881      +49     
+ Misses       1828     1675     -153     
- Partials      440      546     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the fix/expose-window-config branch from aa6bfeb to 76e295e Compare April 5, 2024 13:19
Copy link
Contributor

@Cysword Cysword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test gaan wel fout

@myparcel-bot myparcel-bot bot added the approved (Auto) label Apr 8, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/expose-window-config branch 6 times, most recently from c26704b to 0601723 Compare April 11, 2024 18:06
@EdieLemoine EdieLemoine enabled auto-merge April 15, 2024 09:22
@EdieLemoine EdieLemoine force-pushed the fix/expose-window-config branch from 0601723 to 24ca740 Compare April 15, 2024 09:22
@EdieLemoine EdieLemoine added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 15, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/expose-window-config branch from 24ca740 to 164f6cd Compare April 15, 2024 12:46
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit 164f6cd
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/661d218ef02f910008f1ff6c
😎 Deploy Preview https://deploy-preview-215--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@myparcel-bot myparcel-bot bot force-pushed the fix/expose-window-config branch from 164f6cd to 7a756fd Compare April 15, 2024 14:12
@EdieLemoine EdieLemoine requested a review from a team as a code owner April 15, 2024 14:12
@EdieLemoine EdieLemoine enabled auto-merge April 15, 2024 14:13
@EdieLemoine EdieLemoine added this pull request to the merge queue Apr 15, 2024
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit 7a756fd
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/661d35dff399110008748379
😎 Deploy Preview https://deploy-preview-215--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Merged via the queue into main with commit d717532 Apr 15, 2024
12 checks passed
@EdieLemoine EdieLemoine deleted the fix/expose-window-config branch April 15, 2024 14:15
myparcel-bot bot added a commit that referenced this pull request Apr 15, 2024
## [@myparcel/delivery-options-v6.1.0](v6.0.2...v6.1.0) (2024-04-15)

### ✨ New Features

* **design:** add styling to errors ([a143d55](a143d55))

### 🐛 Bug Fixes

* expose validated config on window object ([#215](#215)) ([d717532](d717532))
* fix non-default package types not working ([#216](#216)) ([1fb7b7c](1fb7b7c))
* select standard delivery initially ([#214](#214)) ([0e67095](0e67095))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Apr 15, 2024

🎉 This PR is included in version @myparcel/delivery-options-v6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants