Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change packets metrics to counter #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

M0NsTeRRR
Copy link
Contributor

fix: #52

This PR is based on my interpretation of metrics from the documentation, as the descriptions for some metrics are not very clear.

Based on :

@Qwiko
Copy link
Contributor

Qwiko commented Mar 25, 2024

I think it looks good.
@mweinelt will have to check and provide feedback.

@mweinelt
Copy link
Owner

mweinelt commented Jun 11, 2024

Sorry for not getting back to you. I'm not super convinced about the overflow handling. Is that really something we have to handle ourselves, or does the client library offer some functionality here?

@M0NsTeRRR
Copy link
Contributor Author

No problems :)

Regarding the overflow, it's something we need to address if we want to handle certain cases. We have two choices:

  • Don't handle counter resets as we can't catch them all the time.
  • Handle them with some logic, which I think should catch most of the cases (current implementation).

The library doesn't deal with counter resets; we have to trigger it ourselves. See prometheus/client_python#995.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packet statistics should use a counter instead of gauge
3 participants