Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packet statistics should use a counter instead of gauge #52

Open
M0NsTeRRR opened this issue Mar 23, 2024 · 2 comments · May be fixed by #53
Open

packet statistics should use a counter instead of gauge #52

M0NsTeRRR opened this issue Mar 23, 2024 · 2 comments · May be fixed by #53

Comments

@M0NsTeRRR
Copy link
Contributor

M0NsTeRRR commented Mar 23, 2024

Packet statistics currently use a gauge, but they should use a counter instead. Kea only increments values for packet statistics since there's a command to reset them to 0.

Kea reset command
Prometheus documentation

@Qwiko
Copy link
Contributor

Qwiko commented Mar 24, 2024

Is there other metrics that also could be represented by a counter? Maybe there are some other metrics that could benefit using a counter instead.

@M0NsTeRRR do you want to work on this and provide some code?

@M0NsTeRRR M0NsTeRRR linked a pull request Mar 24, 2024 that will close this issue
@M0NsTeRRR
Copy link
Contributor Author

I let you review my linked PR @Qwiko :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants