Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mu3] Fix #214996: Add a style option to show measure number range at mmrests #6935

Merged
merged 2 commits into from
Nov 30, 2020
Merged

[mu3] Fix #214996: Add a style option to show measure number range at mmrests #6935

merged 2 commits into from
Nov 30, 2020

Conversation

ecstrema
Copy link
Contributor

@ecstrema ecstrema commented Nov 24, 2020 •
edited
Loading

The MMRestRange is a new class derived from MeasureNumber.
There is 3 possible bracketing around the ranges: parentheses, brackets (the default), or none.

rebased version of #6009 (there's a gif demonstrating the thing in the other PR)

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@ecstrema
Copy link
Contributor Author

ecstrema commented Nov 24, 2020 •
edited
Loading

why is appveyor trying to build this thing?

image

@ecstrema ecstrema force-pushed the mm-range branch 3 times, most recently from 4aa7bb4 to 181d482 Compare November 25, 2020 04:35
@ecstrema ecstrema mentioned this pull request Nov 25, 2020
Closed
8 tasks
@ecstrema ecstrema force-pushed the mm-range branch 3 times, most recently from da6e5e9 to 5dd18f6 Compare November 25, 2020 06:12
@ecstrema ecstrema changed the title Add an option to show measure number interval at mmrests [mu3] Add an option to show measure number interval at mmrests Nov 25, 2020
@igorkorsukov
Copy link
Contributor

why is appveyor trying to build this thing?

image

I think needs rebase. In the root of repo should be file .appveyor_off.yml (should not .appveyor.yml)

@ecstrema ecstrema force-pushed the mm-range branch 4 times, most recently from 9546a68 to bcd32a6 Compare November 25, 2020 18:52
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Nov 25, 2020
Closed
@ecstrema ecstrema force-pushed the mm-range branch 2 times, most recently from 2522f88 to 9a41557 Compare November 26, 2020 17:57
@ecstrema ecstrema marked this pull request as ready for review November 26, 2020 18:10
@ecstrema
Copy link
Contributor Author

ecstrema commented Nov 26, 2020 •
edited
Loading

this one is now ready for review.

@ecstrema ecstrema force-pushed the mm-range branch 2 times, most recently from 855bd02 to 449a631 Compare November 26, 2020 18:59
@ecstrema
fix #214996: Add an option to show measure number interval at mmrests
9f95c8e 
The MMRestRange is a new class derived from MeasureNumber.

MMRestRange may not be styled like MeasureNumber, so a new set of textstyles were added.
There is 3 possible bracketing around the ranges: parentheses, brackets (the default), or none.

Logic is handled by Measure::LayoutMMRestRange.
@ecstrema ecstrema changed the title [mu3] Add an option to show measure number interval at mmrests [mu3] Fix #214996: Add an option to show measure number interval at mmrests Nov 26, 2020
@ecstrema ecstrema changed the title [mu3] Fix #214996: Add an option to show measure number interval at mmrests [mu3] Fix #214996: Add a style option to show measure number range at mmrests Nov 26, 2020
@ecstrema ecstrema force-pushed the mm-range branch 2 times, most recently from 31f332b to 4f09425 Compare November 27, 2020 04:55
@vpereverzev vpereverzev merged commit 12308aa into musescore:3.x Nov 30, 2020
@ecstrema ecstrema mentioned this pull request Nov 30, 2020
Closed
29 tasks
ecstrema added a commit to ecstrema/MuseScore that referenced this pull request Dec 1, 2020
@ecstrema
Followup for PR musescore#6935, that included a bug.
d4085ec 
`MeasureNumber`s and `MMRestRange`s were `delete`d in `measure::remove`,
which caused a crash when undoing the deletion of these elements.
ecstrema added a commit to ecstrema/MuseScore that referenced this pull request Dec 1, 2020
@ecstrema
Followup for PR musescore#6935, that included a bug.
8cba4a0 
`MeasureNumber`s and `MMRestRange`s were `delete`d in `measure::remove`,
which caused a crash when undoing the deletion of these elements.
vpereverzev pushed a commit that referenced this pull request Dec 2, 2020
@ecstrema @vpereverzev
Followup for PR #6935, that included a bug.
01a2b7f 
`MeasureNumber`s and `MMRestRange`s were `delete`d in `measure::remove`,
which caused a crash when undoing the deletion of these elements.
@ecstrema ecstrema deleted the mm-range branch December 8, 2020 21:45
This was referenced Dec 12, 2020
Merged
Merged
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 4, 2021
@igorkorsukov
ported musescore#6935, musescore#6987: Add a style option to show mea…
16b3d8f 
…sure number range at mmrests
@igorkorsukov igorkorsukov mentioned this pull request Feb 4, 2021
Merged
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 4, 2021
@igorkorsukov
ported musescore#6935, musescore#6987: Add a style option to show mea…
ab83e4b 
…sure number range at mmrests
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 4, 2021
@igorkorsukov
ported musescore#6935, musescore#6987: Add a style option to show mea…
cc3f297 
…sure number range at mmrests
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 4, 2021
@igorkorsukov
ported musescore#6935, musescore#6987, musescore#7395: Add a style op…
84a5894 
…tion to show measure number range at mmrests
vpereverzev pushed a commit that referenced this pull request Feb 4, 2021
@igorkorsukov @vpereverzev
ported #6935, #6987, #7395: Add a style option to show measure number…
094cb95 
… range at mmrests
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 4, 2021
@igorkorsukov
ported musescore#6935, musescore#6987, musescore#7395: Add a style op…
3693e33 
…tion to show measure number range at mmrests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecstrema @igorkorsukov @vpereverzev