Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to show measure number intervals at mmrests #6009

Closed
wants to merge 1 commit into from

Conversation

ecstrema
Copy link
Contributor

@ecstrema ecstrema commented Apr 29, 2020

EDIT: rebased version here: #6935

the MMRestRange is a new class derived from MeasureNumber.
The logic is handled by layoutMeasureNumber, as if it was an usual measurenumber.

MMRestRange may not be styled like MeasureNumber, so a new set of textstyles were added.
There is 3 possible bracketing around the ranges: parentheses, brackets, or none (the default).

1

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made. though not many. I will probably add some more, even if it needs to be done in another PR

@ecstrema ecstrema force-pushed the mm-range branch 3 times, most recently from 26cff22 to bd6760e Compare April 29, 2020 06:03
@Jojo-Schmitz
Copy link
Contributor

rebase needed. Also one mtest failed, see https://travis-ci.org/github/musescore/MuseScore/jobs/680872818#L4294

@Jojo-Schmitz
Copy link
Contributor

ping...

@ecstrema
Copy link
Contributor Author

ecstrema commented May 6, 2020

oh yes, thank you. I'll have a look at that today.

@ecstrema ecstrema marked this pull request as draft May 9, 2020 22:55
@ecstrema
Copy link
Contributor Author

ecstrema commented May 9, 2020

The implementation was functional, but not safe enough. I'll rewrite that in a safer manner.

The MMRestRange is a new class derived from MeasureNumber.

MMRestRange may not be styled like MeasureNumber, so a new set of textstyles were added.
There is 3 possible bracketing around the ranges: parentheses, brackets (the default), or none.
@ecstrema ecstrema changed the base branch from master to 3.x November 24, 2020 23:13
@ecstrema ecstrema marked this pull request as ready for review November 24, 2020 23:17
@ecstrema
Copy link
Contributor Author

There's a problem with CI: it shows an appveyor build. (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants