Previous header proof in block structure #6814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node/external/blockAPI/baseBlock.go
Outdated
|
|
||
| func addPreviousHeaderProof(header data.HeaderHandler, apiBlock *api.Block) { | ||
| prevHeaderProof := header.GetPreviousProof() | ||
| if prevHeaderProof == nil { |
There was a problem hiding this comment.
Suggested change
| if prevHeaderProof == nil { | |
| if check.IfNilReflect(prevHeaderProof) { |
| @@ -410,6 +410,34 @@ func TestAddScheduledInfoInBlock(t *testing.T) { | |||
| }, apiBlock) | |||
| } | |||
|
|
|||
| func TestAddPreviousHeaderProofInBlock(t *testing.T) { | |||
| apiBlock := &api.Block{} | ||
| addPreviousHeaderProof(blockHeader, apiBlock) | ||
| require.Equal(t, &api.HeaderProof{ | ||
| PubKeysBitmap: "6269746d6170", |
There was a problem hiding this comment.
maybe use hex.Encode / Decode and extract it to some "provided..." variables, for more clarity?
AdoAdoAdo
previously approved these changes
Feb 18, 2025
sstanculeanu
previously approved these changes
Feb 19, 2025
Base automatically changed from
fixes-delayed-broadcast
to
feat/equivalent-messages
February 19, 2025 14:28
sstanculeanu
dismissed stale reviews from AdoAdoAdo and themself
The base branch was changed.
…re-header-proof # Conflicts: # go.mod # go.sum
sstanculeanu
approved these changes
Feb 19, 2025
AdoAdoAdo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?