-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend block structure #354
Merged
miiu96
merged 6 commits into
feat/header-proof
from
extend-block-structure-proof-fields
Feb 21, 2025
Merged
Extend block structure #354
miiu96
merged 6 commits into
feat/header-proof
from
extend-block-structure-proof-fields
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miiu96
commented
Feb 17, 2025
- Added extra field in API block structure ( information about previous header proof )
sstanculeanu
previously approved these changes
Feb 18, 2025
ssd04
previously approved these changes
Feb 18, 2025
AdoAdoAdo
previously approved these changes
Feb 20, 2025
ssd04
reviewed
Feb 20, 2025
@@ -38,6 +38,20 @@ type Block struct { | |||
EpochStartInfo *EpochStartInfo `json:"epochStartInfo,omitempty"` | |||
EpochStartShardsData []*EpochStartShardData `json:"epochStartShardsData,omitempty"` | |||
ScheduledData *ScheduledData `json:"scheduledData,omitempty"` | |||
PreviousHeaderProof *HeaderProof `json:"previousHeaderProof,omitempty"` | |||
Proof *HeaderProof `json:"proof,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how current proof will be used? when it will be set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current proof will be set on the indexer block
ssd04
approved these changes
Feb 20, 2025
AdoAdoAdo
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.