set MB_PYTHON_OSX_VER default to the newest available #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default for MB_PYTHON_OSX_VER changed from 10.6 to 10.9 for MB_PYTHON_VERSION 2.7.15+ and 3.6+. This should mean users don't have to explicitly set MB_PYTHON_OSX_VER for normal use cases, as most projects only build the latest.
Also adds a new function
macpython_sdk_list_for_versionwhich could be useful for validating MB_PYTHON_OSX_VER / MB_PYTHON_VERSION combinations in future, rather than just letting the python.org download fail if an invalid combination is chosencloses #278