-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aarch64, s390x, ppc64le manylinux2014 support #281
Conversation
README.rst
Outdated
* `1` (see [PEP 513](https://www.python.org/dev/peps/pep-0513); | ||
* `2010` (see [PEP | ||
* `1` corresponding to manylinux1 (see [PEP 513](https://www.python.org/dev/peps/pep-0513); | ||
* `2010` corresponding to manylinux2010 (see [PEP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are to better support searching for "manylinux1" and "manylinux2010"
I only see appveyor checks, shouldn't PRs trigger travis as well? |
manylinux2014 supports and tests aarch64, and will soon get ppc64le support too. Would be nice to support that as well here. |
b0045d4
to
a9c6002
Compare
The |
According to the documentation, bash's |
aarch64 build fails because component you are building has too old 'gnu-config' files. |
it seems that is libtiff. Again (like the question about |
Simple: other platforms are older than aarch64 so libtiff's copy of 'gnu-config' knows them. Update config.{guess,sub} before running "./configure" and it will work. |
3b80d6e
to
1a51f2a
Compare
4b9be05
to
05db7b6
Compare
05db7b6
to
ca5a145
Compare
This PR is now stuck on openblas builds. NumPy is using builds for aarch64 and s390x from packages built and uploaded by @tylerjereddy to a dropbox location. I think it would make sense to copy those to the GF_LIB_URL used here. |
What is wrong with openblas CentOS packages? |
Yum is broken in the image. See the details below. I could download the openblas as used in numpy, but it is a different version. Ideally I would like to get openblas built and uploaded via https://github.com/MacPython/openblas-libs, but in order to do that this PR needs to go in first.
|
Remove /usr/local/lib from LD_LIBRARY_PATH when you call yum? I do not get why you insist on rebuilding most of libraries by hand instead of using distro ones - would make it easier. |
@hrw for NumPy we would like to use OpenBLAS 3.7, which is not available in the distros. |
https://github.com/hrw/multibuild/tree/hrw-devel has gnu-config change. for me openblas build fails due to fetching not existing file |
https://travis-ci.org/hrw/multibuild/jobs/620353346 is travis job for aarch64 |
I was so encouraged by 6989374 passing tests that I tried adding s390x and ppc64le as well, so this still should not be merged |
Looks like ppc64le needs PLAT. |
ppc64le wants config.{guess,sub} update for yaml ;( |
libyaml was 0.1.5, latest is 0.2.2. The Major release announcement did not mention any API changes, so I will upgrade |
Now I think this is ready: the s390x, ppc64le, aarch64 builds passed in isolation. I restored the other CI test runs (lots of macOS there) and updated the README |
The only failing build is a macOS one with the message
Let's leave that for a different "macOS test cleanup" PR (which I have no idea how to do since I know nothing about macOS). |
@matthew-brett any thoughts? |
Seems reasonable to me. Any other takers for review? @radarhere ? |
Co-Authored-By: Andrew Murray <3112309+radarhere@users.noreply.github.com>
All builds are green. |
Let's give it a shot ... |
@matthew-brett yes, this fail seems to have been due to the policy for macOS builds prior to #279 when it would default to building for 10.6 / dual arch for everything except see https://travis-ci.org/matthew-brett/multibuild/jobs/620819251#L389 |
No description provided.