Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Keep monorepo up-to-date automatically #3500

Closed

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 23, 2021

Try to fix mui/material-ui#30122 (comment). I'm not sure if this will work, based on https://docs.renovatebot.com/modules/datasource/.

@m4theushw
Copy link
Member

m4theushw commented Dec 23, 2021

I tried this in #2924 and #2925 but it didn't work, then #2926 reverted.

The git data source is not suitable to the way that the monorepo dependency is specified. I wished that Renovate had better docs for it.

See the reason of why the monorepo got skipped in another job.

image

It's being skipped in the npm data source: https://github.com/renovatebot/renovate/blob/597da6ff59e5a3c984c0b7d0db91d13114512b26/lib/manager/npm/extract/index.ts#L326

I have a TODO item to check if it's viable to add support to branch-based refs on Renovate. See renovatebot/renovate#5640

For now, I'm not keeping a strict track of how many weeks the monorepo version is behind the Core. The last update was 16 days ago in #3370. We can assume that it will get updated at least each month.

{
"groupName": "monorepo",
"matchPackageNames": ["@material-ui/monorepo"],
"matchUpdateTypes": ["lockFileMaintenance"]
Copy link
Member

@m4theushw m4theushw Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in https://github.com/m4theushw/renovate-playground/blob/main/renovate.json and it didn't work. If lockFileMaintenance is not enabled, setting this option to this value doesn't have effect.

The config here means: add the monorepo group to the package @material-ui/monorepo updated via lockFileMaintenance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright you seem to have this under better hands than mine, I'm giving up 😁

@oliviertassinari oliviertassinari deleted the renovate-mono-repo branch January 3, 2022 21:11
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants