[survey] Remove survey promotion items

[danilo-leal]

To be merged before this week's release as the survey closes for answers on Tuesday, Dec 14th.

• Remove banner from the marketing pages.
• Remove the card from docs' table of contents.
• Remove notification.
• Make the banner component generic so it can be used in the future again.

[mui-pr-bot]

No bundle size changes

Generated by 🚫 dangerJS against 1d5808f

[mnajdova]

👍

[oliviertassinari]

Should we remove the notification too?

[mbrookes]

I'd suggest reverting the previous commits rather than manually removing the changes.

[danilo-leal]

What's the difference between this approach and reverting the commits? I really don't know.

[oliviertassinari]

One point I wonder about: Should we leave some infrastructure in place for the next time we want to add a banner? For instance, we have kept SurveyBanner.js from #29950.

---

What's the difference between this approach and reverting the commits? I really don't know.

I think that it's well covered in https://www.atlassian.com/git/tutorials/undoing-changes/git-revert.

[mbrookes]

What's the difference between this approach and reverting the commits?

I just meant for the future. It's quicker and easier, and less likely to miss something. Also easier to review, as you're only concerned with checking that the appropriate commits are reverted.

[mbrookes]

To be merged only on Dec 13th

Or at any point. The docs shouldn't published at a newer commit in the meantime, as that risks the content being out of sync with the published packages.

[mnajdova]

If we want to keep the banner generic, we should still import it from all the pages we had before, just use the new name WebsiteBanner

[siriwatknp]

Updated to use feature toggle to hide the banner.

[oliviertassinari]

Nice new AppHeaderBanner component 👌

[oliviertassinari]

Note: this PR is not enough to remove all the survey, it's still present in MUI X, e.g.

https://mui.com/components/data-grid/editing/

It's a bit confusing to see the banner, clicking on it to have:

cc @mui-org/x

[danilo-leal]

The survey card isn't the only confusing thing though, https://mui.com/components/data-grid/ is still showing to me as v5.2.3, click in any Core component and then v5.2.5. So maybe it's something even bigger than the scope of this PR?!

[oliviertassinari]

Yes, definitely. It suggests that we need to upgrade the dependency on the mono-repo in X, it hasn't been updated for > 3 weeks. I wonder if renovate could do it for us every week.