Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.22.1 #15209

Merged
merged 21 commits into from
Nov 1, 2024
Merged

v7.22.1 #15209

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4cd3117
core: changelog
romgrk Oct 31, 2024
a1201b5
lint
romgrk Oct 31, 2024
a5eb9e2
Update CHANGELOG.md
romgrk Oct 31, 2024
5dc0f4e
Update CHANGELOG.md
romgrk Oct 31, 2024
4a2cc53
Update packages/x-charts-pro/package.json
romgrk Oct 31, 2024
4c6e1d5
Update CHANGELOG.md
romgrk Oct 31, 2024
84a6668
Update CHANGELOG.md
romgrk Oct 31, 2024
19d1bbe
Update CHANGELOG.md
romgrk Oct 31, 2024
4abbdd6
Update CHANGELOG.md
romgrk Oct 31, 2024
f4262ea
Update CHANGELOG.md
romgrk Oct 31, 2024
bd793b8
lint
romgrk Oct 31, 2024
f2f12ee
Update CHANGELOG.md
romgrk Oct 31, 2024
1a0082b
Update CHANGELOG.md
romgrk Oct 31, 2024
ffc80d6
Update CHANGELOG.md
romgrk Oct 31, 2024
58628a4
lint
romgrk Oct 31, 2024
822ecd1
Merge branch 'release-7.22.1' of github.com:romgrk/mui-x into release…
romgrk Oct 31, 2024
dbd3249
lint
romgrk Oct 31, 2024
18ca254
lint
romgrk Oct 31, 2024
02ce159
Merge branch 'v7.x' into release-7.22.1
romgrk Nov 1, 2024
f3e42ca
Update CHANGELOG.md
romgrk Nov 1, 2024
618ee17
Update CHANGELOG.md
romgrk Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
romgrk marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,62 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## 7.22.1

_Nov 1, 2024_

We'd like to offer a big thanks to the 6 contributors who made this release possible. Here are some highlights ✨:

Check warning on line 10 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'We'.

Raw Output:
{"message": "[Google.We] Try to avoid using first-person plural like 'We'.", "location": {"path": "CHANGELOG.md", "range": {"start": {"line": 10, "column": 1}}}, "severity": "WARNING"}
romgrk marked this conversation as resolved.
Show resolved Hide resolved

- 🐞 Bugfixes
- 📚 Documentation improvements
- 🌍 Improve Polish (plPL) locale on the Date Pickers
romgrk marked this conversation as resolved.
Show resolved Hide resolved

Special thanks go out to the community contributors who have helped make this release possible:
@wojtkolos, @dpak-maurya.
Following are all team members who have contributed to this release:
@LukasTy, @arminmeh, @MBilalShafi, @KenanYusuf.
romgrk marked this conversation as resolved.
Show resolved Hide resolved

<!--/ HIGHLIGHT_ABOVE_SEPARATOR /-->

### Data Grid

#### `@mui/x-data-grid@7.22.1`

- [DataGrid] Fix right column group header border (#15152) @KenanYusuf
- [DataGrid] Fix scroll jump when holding down arrow keys (#15167) @arminmeh
- [DataGrid] Move `rowGroupingModelChange` handler to respective hook (#15127) @MBilalShafi
- [DataGrid] Prevent error when deleting the last row (#15153) @dpak-maurya

#### `@mui/x-data-grid-pro@7.22.1` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')

Same changes as in `@mui/x-data-grid@7.22.1`, plus:

- [DataGridPro] Add list view tests (#15166) @KenanYusuf

#### `@mui/x-data-grid-premium@7.22.1` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link 'Premium plan')

Same changes as in `@mui/x-data-grid-pro@7.22.1`.

### Date and Time Pickers

#### `@mui/x-date-pickers@7.22.1`

- [l10n] Improve Polish (plPL) locale (#15177) @wojtkolos
romgrk marked this conversation as resolved.
Show resolved Hide resolved

#### `@mui/x-date-pickers-pro@7.22.1` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link 'Pro plan')

Same changes as in `@mui/x-date-pickers@7.22.1`.

### Tree View

#### `@mui/x-tree-view@7.22.1`

- [TreeView] Fix drag and drop color usage (#15149) @LukasTy
romgrk marked this conversation as resolved.
Show resolved Hide resolved
romgrk marked this conversation as resolved.
Show resolved Hide resolved

romgrk marked this conversation as resolved.
Show resolved Hide resolved
### Docs

- [docs] Add section explaining how to keep the selection while filtering in Data grid docs (#15199) @arminmeh

## 7.22.0

_Oct 25, 2024_
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "7.22.0",
"version": "7.22.1",
"private": true,
"scripts": {
"preinstall": "npx only-allow pnpm",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-charts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-charts",
"version": "7.22.0",
"version": "7.22.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it done automatically? because I don't see what modification happend

Suggested change
"version": "7.22.1",
"version": "7.22.0",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, doesn't look like anything changed between 7.22.0 and now. 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather do an empty release and keep all the version numbers in sync, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like we are having this debate every two weeks 😆
Our decision in the general meeting a few month ago was to just follow what Lerna updates, to at least be consistent everytime.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time when I was releasing we "agreed" to release all packages regardless
#14910 (comment)
Script was updated to reflect that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the problem/question in this case is clear.
We have two cases:

  1. We currently do not release when Lerna doesn't detect any changes and there were no specific changes in the package;
  2. We release, but mention no changes in the CHANGELOG when no specific changes happened on the package, but Lerna detects changes (usually because of dependencies bumping)

This difference in approach is somewhat confusing and leads to unstable results. 🤔

This is why I slightly prefer the more manual approach—releasing only the packages with changes to it and skipping in case of dependency bumping.

WDYT about the compromise of not listing the package in the changelog if it doesn't have any changes in the 2nd case? 🤔

Copy link
Member

@flaviendelangle flaviendelangle Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time when I was releasing we "agreed" to release all packages regardless

That's not what I understand from this discussion.
Lerna can release packages without PR tight to it (if you have a dep that was updated for example).

See #14910 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about the compromise of not listing the package in the changelog if it doesn't have any changes in the 2nd case? 🤔

I think we should list the package in the changelog if it was released, even if there are no notable changes.
And whether we should release the package or not – determined by Lerna.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I'm fine with that as well.
But this approach is still creating debates, that is why we can possibly improve it. 👍 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time when I was releasing we "agreed" to release all packages regardless

That's not what I understand from this discussion.

Here we go again 😅
I've opened #15219 to clarify this in the release instructions.
I'm gonna need each team's approval on it to make sure we're on the same page.
If there's anything to discuss or clarify further – leave a comment in #15219

"description": "The community edition of the Charts components (MUI X).",
"author": "MUI Team",
"main": "src/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-generator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-generator",
"version": "7.22.0",
"version": "7.22.1",
"description": "Generate fake data for demo purposes only.",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-premium/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-premium",
"version": "7.22.0",
"version": "7.22.1",
"description": "The Premium plan edition of the Data Grid Components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid-pro",
"version": "7.22.0",
"version": "7.22.1",
"description": "The Pro plan edition of the Data Grid components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-data-grid",
"version": "7.22.0",
"version": "7.22.1",
"description": "The Community plan edition of the Data Grid components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-date-pickers-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-date-pickers-pro",
"version": "7.22.0",
"version": "7.22.1",
"description": "The Pro plan edition of the Date and Time Picker components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-date-pickers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-date-pickers",
"version": "7.22.0",
"version": "7.22.1",
"description": "The community edition of the Date and Time Picker components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-tree-view-pro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-tree-view-pro",
"version": "7.22.0",
"version": "7.22.1",
"description": "The Pro plan edition of the Tree View components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/x-tree-view/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mui/x-tree-view",
"version": "7.22.0",
"version": "7.22.1",
"description": "The community edition of the Tree View components (MUI X).",
"author": "MUI Team",
"main": "src/index.ts",
Expand Down
Loading