v7.22.1 #15209
v7.22.1 #15209
Conversation
|
Deploy preview: https://deploy-preview-15209--material-ui-x.netlify.app/ |
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@mui/x-charts", | |||
| "version": "7.22.0", | |||
| "version": "7.22.1", | |||
There was a problem hiding this comment.
Is it done automatically? because I don't see what modification happend
| "version": "7.22.1", | |
| "version": "7.22.0", |
There was a problem hiding this comment.
Agreed, doesn't look like anything changed between 7.22.0 and now. 🤷
There was a problem hiding this comment.
I'd rather do an empty release and keep all the version numbers in sync, wdyt?
There was a problem hiding this comment.
Feel like we are having this debate every two weeks 😆
Our decision in the general meeting a few month ago was to just follow what Lerna updates, to at least be consistent everytime.
There was a problem hiding this comment.
Last time when I was releasing we "agreed" to release all packages regardless
#14910 (comment)
Script was updated to reflect that
There was a problem hiding this comment.
Ok, the problem/question in this case is clear.
We have two cases:
- We currently do not release when Lerna doesn't detect any changes and there were no specific changes in the package;
- We release, but mention no changes in the CHANGELOG when no specific changes happened on the package, but Lerna detects changes (usually because of dependencies bumping)
This difference in approach is somewhat confusing and leads to unstable results. 🤔
This is why I slightly prefer the more manual approach—releasing only the packages with changes to it and skipping in case of dependency bumping.
WDYT about the compromise of not listing the package in the changelog if it doesn't have any changes in the 2nd case? 🤔
There was a problem hiding this comment.
Last time when I was releasing we "agreed" to release all packages regardless
That's not what I understand from this discussion.
Lerna can release packages without PR tight to it (if you have a dep that was updated for example).
See #14910 (comment)
There was a problem hiding this comment.
WDYT about the compromise of not listing the package in the changelog if it doesn't have any changes in the 2nd case? 🤔
I think we should list the package in the changelog if it was released, even if there are no notable changes.
And whether we should release the package or not – determined by Lerna.
There was a problem hiding this comment.
Gotcha, I'm fine with that as well.
But this approach is still creating debates, that is why we can possibly improve it. 👍 🤔
There was a problem hiding this comment.
Last time when I was releasing we "agreed" to release all packages regardless
That's not what I understand from this discussion.
Here we go again 😅
I've opened #15219 to clarify this in the release instructions.
I'm gonna need each team's approval on it to make sure we're on the same page.
If there's anything to discuss or clarify further – leave a comment in #15219
alexfauquette
requested review from
flaviendelangle,
LukasTy and
cherniavskii
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@mui/x-charts", | |||
| "version": "7.22.0", | |||
| "version": "7.22.1", | |||
There was a problem hiding this comment.
Agreed, doesn't look like anything changed between 7.22.0 and now. 🤷
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
No description provided.