-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Align grid cell tooltip with the column header #14484
Open
arminmeh
wants to merge
4
commits into
mui:master
Choose a base branch
from
arminmeh:grid-cell-tooltip
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
accessibility
a11y
component: data grid
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
labels
Sep 4, 2024
Deploy preview: https://deploy-preview-14484--material-ui-x.netlify.app/ |
arminmeh
force-pushed
the
grid-cell-tooltip
branch
from
September 5, 2024 09:35
1381ec3
to
1dcf036
Compare
arminmeh
force-pushed
the
grid-cell-tooltip
branch
from
September 11, 2024 22:02
1dcf036
to
ce452ad
Compare
arminmeh
force-pushed
the
grid-cell-tooltip
branch
from
September 11, 2024 22:36
ce452ad
to
5e90ef0
Compare
arminmeh
commented
Sep 12, 2024
@@ -30,6 +30,12 @@ const GridColumnHeaderTitleRoot = styled('div', { | |||
whiteSpace: 'nowrap', | |||
fontWeight: 'var(--unstable_DataGrid-headWeight)', | |||
lineHeight: 'normal', | |||
// To prevent Safari adding its own tooltip for truncated text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is still present on the GridCell
, but I couldn't apply the same because it would impact performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
a11y
component: data grid
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #9954 I have noticed that sometimes the cell values are read twice as well.
This occurs because of the
title
prop that was added in #7671Accessibility tools were already showing warnings for this approach.
Since column header component is using tooltip to show the whole content, I have added the same to the cells and removed the
title
prop.This introduced a small UX issue, since the cell text content is added directly to the cell container to reduce the number of nodes. Tooltip shows up way below the cell, because it has a default margin relative to the target element.
I have added a default
slotProp
value for theTooltip
component, to render it just a bit over the bottom borderWith default margins
With mt = -5px
To allow changes, I repeated this pattern (but with default)
Issue that should bring this topic even further #7323