[DataGridPro] onRowsScrollEnd not firing on very fast scrolling #14171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
bug 🐛
|
Deploy preview: https://deploy-preview-14171--material-ui-x.netlify.app/ |
MBilalShafi
reviewed
Aug 13, 2024
packages/x-data-grid-pro/src/hooks/features/infiniteLoader/useGridInfiniteLoader.tsx
Outdated
Show resolved
Hide resolved
packages/x-data-grid-pro/src/hooks/features/infiniteLoader/useGridInfiniteLoader.tsx
Show resolved
Hide resolved
romgrk
reviewed
Aug 13, 2024
packages/x-data-grid-pro/src/hooks/features/infiniteLoader/useGridInfiniteLoader.tsx
Outdated
Show resolved
Hide resolved
arminmeh
force-pushed
the
onRowsScrollEnd-not-firing
branch
2 times, most recently
from
1ac6ca7 to
5b78c68
Compare
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com>
arminmeh
force-pushed
the
onRowsScrollEnd-not-firing
branch
from
5b78c68 to
6758923
Compare
cherniavskii
approved these changes
Sep 30, 2024
Comment on lines
+116
to
+118
| updateTargetTimeout.start(0, () => updateTarget(node)); | ||
| }, | ||
| [isEnabled], | ||
| [isEnabled, updateTargetTimeout], |
There was a problem hiding this comment.
TIL eslint-plugin-react-hooks is smart enough not to require updateTarget as a dependency here because it doesn't rely on any state that might change 🤯
packages/x-data-grid-pro/src/hooks/features/infiniteLoader/useGridInfiniteLoader.tsx
Show resolved
Hide resolved
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14116
As written in the code comment
with fast scrolling, intersection observer may get connected to the target object, call the callback with the params that show that the intersection is not happening, but then fail to report that the intersection happen short after that (because it happened under single render cycle)
https://deploy-preview-14171--material-ui-x.netlify.app/x/react-data-grid/row-updates/