Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Infinite loading onRowsScrollEnd intermittent issue not firing #14116

Closed
1 task done
eversadi opened this issue Aug 6, 2024 · 8 comments · Fixed by #14171
Closed
1 task done

[DataGridPro] Infinite loading onRowsScrollEnd intermittent issue not firing #14116

eversadi opened this issue Aug 6, 2024 · 8 comments · Fixed by #14171
Assignees
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row loading Related to the data grid Row loading features

Comments

@eversadi
Copy link

eversadi commented Aug 6, 2024

Latest version

  • I have tested the latest version

Steps to reproduce

Link to live example: (required)

https://codesandbox.io/s/s9zvh2?file=/src/Demo.js

video here

Steps:

  1. just scroll down to the end of the scroll load the data from the mui example

Current behavior

Data Grid onRowsScrollEnd event does not fire , it just stop at the bottom

Expected behavior

Data Grid onRowsScrollEnd should always fire once reach the end of the scrollbar

Context

I wan't to have a table that can loads a data when the scroll position is at the bottom
icy-paper-s9zvh2 - CodeSandbox.webm

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: onRowsScrollEnd
Order ID: eversadi-1

@eversadi eversadi added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 6, 2024
@github-actions github-actions bot added the component: data grid This is the name of the generic UI component, not the React module! label Aug 6, 2024
@arminmeh
Copy link
Contributor

arminmeh commented Aug 6, 2024

Can confirm on our own example as well.

Thanks for reporting @eversadi

@arminmeh arminmeh removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 6, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Aug 6, 2024
@arminmeh arminmeh moved this from 🆕 Needs refinement to 🔖 Ready in MUI X Data Grid Aug 6, 2024
@arminmeh arminmeh changed the title Data Grid Pro Infinite loading onRowsScrollEnd intermittent issue not firing [DataGridPro] Infinite loading onRowsScrollEnd intermittent issue not firing Aug 6, 2024
@arminmeh arminmeh self-assigned this Aug 8, 2024
@arminmeh arminmeh moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Aug 8, 2024
@arminmeh arminmeh moved this from 🏗 In progress to 👀 In review in MUI X Data Grid Aug 12, 2024
@lukedukeus
Copy link

Just ran into this issue. I found that using disableVirtualization got rid of it, but then everything renders much slower. I found that I was also much more likely to run into this if I had complex logic for my renderCell method.

@arminmeh
Copy link
Contributor

thanks @lukedukeus
this helps reproduce the issue

Copy link

github-actions bot commented Oct 1, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @eversadi! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

@arminmeh arminmeh moved this from 👀 In review to ✅ Done in MUI X Data Grid Oct 1, 2024
@kfowler1337
Copy link

How do I know when this is released? Hit the same issue @arminmeh

@arminmeh
Copy link
Contributor

arminmeh commented Oct 9, 2024

@kfowler1337
It has been released in 7.19.0
Are you using that version?

@efotin
Copy link

efotin commented Oct 9, 2024

Will it be released for v6 premium?

@arminmeh arminmeh added the feature: Row loading Related to the data grid Row loading features label Oct 10, 2024
@arminmeh
Copy link
Contributor

@efotin
Infinite loading was re-worked for version 7
so the change made here cannot be ported back.
since it is not a regression or a security issue, there is no plan to fix this on v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row loading Related to the data grid Row loading features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants